refactor: switch to React Router #1115
Open
+18,780
−197,170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderochervlk
force-pushed
the
vlk-v12-react-router
branch
from
3d98702 to
71c2897
Compare
Deploying rescript-lang-org with
|
| Latest commit: |
59c4de5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e40a49d7.rescript-lang.pages.dev |
| Branch Preview URL: | https://vlk-v12-react-router.rescript-lang.pages.dev |
…ript-lang/rescript-lang.org into vlk-v12-react-router
…ript-lang/rescript-lang.org into vlk-v12-react-router
…nto vlk-v12-react-router
…nto vlk-v12-react-router
Member
|
Edit link still didn't work for me: 
|
Member
leads to 404 |
Member
doesn't seem to open the playground with that exact code snippet. |
Collaborator
Author
They won't work until the changes are on the master branch. I can probably make this an env variable or something. |
Member
Okay, that is fine. No need to spend time on this if it will work on master. |
Collaborator
Author
Fixed. |
Collaborator
Author
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.